Fix dockerfile

Major bump since dropping support for python <3.8

.github/workflows/package.yml

@@ -38,7 +38,7 @@ jobs:
       max-parallel: 9
       fail-fast: false
       matrix:
-        python-version: [3.7, 3.8]
+        python-version: [3.8, 3.9, 3.10]
         os: [ubuntu-latest, windows-latest, macOS-latest]
 
     steps:

.gitignore

@@ -1,3 +1,4 @@
+geckodriver.log
 
 # Created by https://www.gitignore.io/api/osx,pycharm,python
 # Edit at https://www.gitignore.io/?templates=osx,pycharm,python
@@ -226,3 +227,4 @@ dmypy.json
 # End of https://www.gitignore.io/api/osx,pycharm,python
 
 .idea
+.vscode

.pre-commit-config.yaml

@@ -0,0 +1,33 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.0.1
+    hooks:
+      - id: check-ast
+        types: [python]
+      - id: check-json
+        types: [json]
+      - id: check-toml
+        types: [toml]
+      - id: check-yaml
+        types: [yaml]
+        args: [--allow-multiple-documents]
+#      - id: check-xml
+#        types: [xml]
+      - id: end-of-file-fixer
+      - id: pretty-format-json
+        args:
+          - --autofix
+          - --no-sort-keys
+      - id: trailing-whitespace
+        args:
+          - --markdown-linebreak-ext=md
+  - repo: https://github.com/timothycrosley/isort
+    rev: 5.10.1
+    hooks:
+      - id: isort
+        types: [python]
+  - repo: https://github.com/psf/black
+    rev: 21.11b1
+    hooks:
+    - id: black
+      types: [python]

Dockerfile

@@ -0,0 +1,13 @@
+FROM debian:bullseye AS downloader
+WORKDIR /app
+RUN apt-get update && apt-get install -y wget
+ARG GECKODRIVER_VERSION="v0.30.0"
+ARG GECKODRIVER_FILENAME="geckodriver-$GECKODRIVER_VERSION-linux64"
+RUN wget -q https://github.com/mozilla/geckodriver/releases/download/$GECKODRIVER_VERSION/$GECKODRIVER_FILENAME.tar.gz && tar xvf $GECKODRIVER_FILENAME.tar.gz && rm $GECKODRIVER_FILENAME.tar.gz
+
+FROM python:3.10-slim-bullseye as final
+RUN apt-get update && apt-get install -y firefox-esr
+COPY --from=downloader /app/geckodriver /usr/local/bin/geckodriver
+ARG OFX_VERSION
+RUN pip install ofx-processor==$OFX_VERSION
+CMD ["ynab", "lcl", "--download"]

LICENSE

@@ -1,674 +1,25 @@
-                    GNU GENERAL PUBLIC LICENSE
-                       Version 3, 29 June 2007
+This is free and unencumbered software released into the public domain.
+
+Anyone is free to copy, modify, publish, use, compile, sell, or
+distribute this software, either in source code form or as a compiled
+binary, for any purpose, commercial or non-commercial, and by any
+means.
+
+In jurisdictions that recognize copyright laws, the author or authors
+of this software dedicate any and all copyright interest in the
+software to the public domain. We make this dedication for the benefit
+of the public at large and to the detriment of our heirs and
+successors. We intend this dedication to be an overt act of
+relinquishment in perpetuity of all present and future rights to this
+software under copyright law.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+OTHER DEALINGS IN THE SOFTWARE.
+
+For more information, please refer to <https://unlicense.org>
 
- Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
-
-                            Preamble
-
-  The GNU General Public License is a free, copyleft license for
-software and other kinds of works.
-
-  The licenses for most software and other practical works are designed
-to take away your freedom to share and change the works.  By contrast,
-the GNU General Public License is intended to guarantee your freedom to
-share and change all versions of a program--to make sure it remains free
-software for all its users.  We, the Free Software Foundation, use the
-GNU General Public License for most of our software; it applies also to
-any other work released this way by its authors.  You can apply it to
-your programs, too.
-
-  When we speak of free software, we are referring to freedom, not
-price.  Our General Public Licenses are designed to make sure that you
-have the freedom to distribute copies of free software (and charge for
-them if you wish), that you receive source code or can get it if you
-want it, that you can change the software or use pieces of it in new
-free programs, and that you know you can do these things.
-
-  To protect your rights, we need to prevent others from denying you
-these rights or asking you to surrender the rights.  Therefore, you have
-certain responsibilities if you distribute copies of the software, or if
-you modify it: responsibilities to respect the freedom of others.
-
-  For example, if you distribute copies of such a program, whether
-gratis or for a fee, you must pass on to the recipients the same
-freedoms that you received.  You must make sure that they, too, receive
-or can get the source code.  And you must show them these terms so they
-know their rights.
-
-  Developers that use the GNU GPL protect your rights with two steps:
-(1) assert copyright on the software, and (2) offer you this License
-giving you legal permission to copy, distribute and/or modify it.
-
-  For the developers' and authors' protection, the GPL clearly explains
-that there is no warranty for this free software.  For both users' and
-authors' sake, the GPL requires that modified versions be marked as
-changed, so that their problems will not be attributed erroneously to
-authors of previous versions.
-
-  Some devices are designed to deny users access to install or run
-modified versions of the software inside them, although the manufacturer
-can do so.  This is fundamentally incompatible with the aim of
-protecting users' freedom to change the software.  The systematic
-pattern of such abuse occurs in the area of products for individuals to
-use, which is precisely where it is most unacceptable.  Therefore, we
-have designed this version of the GPL to prohibit the practice for those
-products.  If such problems arise substantially in other domains, we
-stand ready to extend this provision to those domains in future versions
-of the GPL, as needed to protect the freedom of users.
-
-  Finally, every program is threatened constantly by software patents.
-States should not allow patents to restrict development and use of
-software on general-purpose computers, but in those that do, we wish to
-avoid the special danger that patents applied to a free program could
-make it effectively proprietary.  To prevent this, the GPL assures that
-patents cannot be used to render the program non-free.
-
-  The precise terms and conditions for copying, distribution and
-modification follow.
-
-                       TERMS AND CONDITIONS
-
-  0. Definitions.
-
-  "This License" refers to version 3 of the GNU General Public License.
-
-  "Copyright" also means copyright-like laws that apply to other kinds of
-works, such as semiconductor masks.
-
-  "The Program" refers to any copyrightable work licensed under this
-License.  Each licensee is addressed as "you".  "Licensees" and
-"recipients" may be individuals or organizations.
-
-  To "modify" a work means to copy from or adapt all or part of the work
-in a fashion requiring copyright permission, other than the making of an
-exact copy.  The resulting work is called a "modified version" of the
-earlier work or a work "based on" the earlier work.
-
-  A "covered work" means either the unmodified Program or a work based
-on the Program.
-
-  To "propagate" a work means to do anything with it that, without
-permission, would make you directly or secondarily liable for
-infringement under applicable copyright law, except executing it on a
-computer or modifying a private copy.  Propagation includes copying,
-distribution (with or without modification), making available to the
-public, and in some countries other activities as well.
-
-  To "convey" a work means any kind of propagation that enables other
-parties to make or receive copies.  Mere interaction with a user through
-a computer network, with no transfer of a copy, is not conveying.
-
-  An interactive user interface displays "Appropriate Legal Notices"
-to the extent that it includes a convenient and prominently visible
-feature that (1) displays an appropriate copyright notice, and (2)
-tells the user that there is no warranty for the work (except to the
-extent that warranties are provided), that licensees may convey the
-work under this License, and how to view a copy of this License.  If
-the interface presents a list of user commands or options, such as a
-menu, a prominent item in the list meets this criterion.
-
-  1. Source Code.
-
-  The "source code" for a work means the preferred form of the work
-for making modifications to it.  "Object code" means any non-source
-form of a work.
-
-  A "Standard Interface" means an interface that either is an official
-standard defined by a recognized standards body, or, in the case of
-interfaces specified for a particular programming language, one that
-is widely used among developers working in that language.
-
-  The "System Libraries" of an executable work include anything, other
-than the work as a whole, that (a) is included in the normal form of
-packaging a Major Component, but which is not part of that Major
-Component, and (b) serves only to enable use of the work with that
-Major Component, or to implement a Standard Interface for which an
-implementation is available to the public in source code form.  A
-"Major Component", in this context, means a major essential component
-(kernel, window system, and so on) of the specific operating system
-(if any) on which the executable work runs, or a compiler used to
-produce the work, or an object code interpreter used to run it.
-
-  The "Corresponding Source" for a work in object code form means all
-the source code needed to generate, install, and (for an executable
-work) run the object code and to modify the work, including scripts to
-control those activities.  However, it does not include the work's
-System Libraries, or general-purpose tools or generally available free
-programs which are used unmodified in performing those activities but
-which are not part of the work.  For example, Corresponding Source
-includes interface definition files associated with source files for
-the work, and the source code for shared libraries and dynamically
-linked subprograms that the work is specifically designed to require,
-such as by intimate data communication or control flow between those
-subprograms and other parts of the work.
-
-  The Corresponding Source need not include anything that users
-can regenerate automatically from other parts of the Corresponding
-Source.
-
-  The Corresponding Source for a work in source code form is that
-same work.
-
-  2. Basic Permissions.
-
-  All rights granted under this License are granted for the term of
-copyright on the Program, and are irrevocable provided the stated
-conditions are met.  This License explicitly affirms your unlimited
-permission to run the unmodified Program.  The output from running a
-covered work is covered by this License only if the output, given its
-content, constitutes a covered work.  This License acknowledges your
-rights of fair use or other equivalent, as provided by copyright law.
-
-  You may make, run and propagate covered works that you do not
-convey, without conditions so long as your license otherwise remains
-in force.  You may convey covered works to others for the sole purpose
-of having them make modifications exclusively for you, or provide you
-with facilities for running those works, provided that you comply with
-the terms of this License in conveying all material for which you do
-not control copyright.  Those thus making or running the covered works
-for you must do so exclusively on your behalf, under your direction
-and control, on terms that prohibit them from making any copies of
-your copyrighted material outside their relationship with you.
-
-  Conveying under any other circumstances is permitted solely under
-the conditions stated below.  Sublicensing is not allowed; section 10
-makes it unnecessary.
-
-  3. Protecting Users' Legal Rights From Anti-Circumvention Law.
-
-  No covered work shall be deemed part of an effective technological
-measure under any applicable law fulfilling obligations under article
-11 of the WIPO copyright treaty adopted on 20 December 1996, or
-similar laws prohibiting or restricting circumvention of such
-measures.
-
-  When you convey a covered work, you waive any legal power to forbid
-circumvention of technological measures to the extent such circumvention
-is effected by exercising rights under this License with respect to
-the covered work, and you disclaim any intention to limit operation or
-modification of the work as a means of enforcing, against the work's
-users, your or third parties' legal rights to forbid circumvention of
-technological measures.
-
-  4. Conveying Verbatim Copies.
-
-  You may convey verbatim copies of the Program's source code as you
-receive it, in any medium, provided that you conspicuously and
-appropriately publish on each copy an appropriate copyright notice;
-keep intact all notices stating that this License and any
-non-permissive terms added in accord with section 7 apply to the code;
-keep intact all notices of the absence of any warranty; and give all
-recipients a copy of this License along with the Program.
-
-  You may charge any price or no price for each copy that you convey,
-and you may offer support or warranty protection for a fee.
-
-  5. Conveying Modified Source Versions.
-
-  You may convey a work based on the Program, or the modifications to
-produce it from the Program, in the form of source code under the
-terms of section 4, provided that you also meet all of these conditions:
-
-    a) The work must carry prominent notices stating that you modified
-    it, and giving a relevant date.
-
-    b) The work must carry prominent notices stating that it is
-    released under this License and any conditions added under section
-    7.  This requirement modifies the requirement in section 4 to
-    "keep intact all notices".
-
-    c) You must license the entire work, as a whole, under this
-    License to anyone who comes into possession of a copy.  This
-    License will therefore apply, along with any applicable section 7
-    additional terms, to the whole of the work, and all its parts,
-    regardless of how they are packaged.  This License gives no
-    permission to license the work in any other way, but it does not
-    invalidate such permission if you have separately received it.
-
-    d) If the work has interactive user interfaces, each must display
-    Appropriate Legal Notices; however, if the Program has interactive
-    interfaces that do not display Appropriate Legal Notices, your
-    work need not make them do so.
-
-  A compilation of a covered work with other separate and independent
-works, which are not by their nature extensions of the covered work,
-and which are not combined with it such as to form a larger program,
-in or on a volume of a storage or distribution medium, is called an
-"aggregate" if the compilation and its resulting copyright are not
-used to limit the access or legal rights of the compilation's users
-beyond what the individual works permit.  Inclusion of a covered work
-in an aggregate does not cause this License to apply to the other
-parts of the aggregate.
-
-  6. Conveying Non-Source Forms.
-
-  You may convey a covered work in object code form under the terms
-of sections 4 and 5, provided that you also convey the
-machine-readable Corresponding Source under the terms of this License,
-in one of these ways:
-
-    a) Convey the object code in, or embodied in, a physical product
-    (including a physical distribution medium), accompanied by the
-    Corresponding Source fixed on a durable physical medium
-    customarily used for software interchange.
-
-    b) Convey the object code in, or embodied in, a physical product
-    (including a physical distribution medium), accompanied by a
-    written offer, valid for at least three years and valid for as
-    long as you offer spare parts or customer support for that product
-    model, to give anyone who possesses the object code either (1) a
-    copy of the Corresponding Source for all the software in the
-    product that is covered by this License, on a durable physical
-    medium customarily used for software interchange, for a price no
-    more than your reasonable cost of physically performing this
-    conveying of source, or (2) access to copy the
-    Corresponding Source from a network server at no charge.
-
-    c) Convey individual copies of the object code with a copy of the
-    written offer to provide the Corresponding Source.  This
-    alternative is allowed only occasionally and noncommercially, and
-    only if you received the object code with such an offer, in accord
-    with subsection 6b.
-
-    d) Convey the object code by offering access from a designated
-    place (gratis or for a charge), and offer equivalent access to the
-    Corresponding Source in the same way through the same place at no
-    further charge.  You need not require recipients to copy the
-    Corresponding Source along with the object code.  If the place to
-    copy the object code is a network server, the Corresponding Source
-    may be on a different server (operated by you or a third party)
-    that supports equivalent copying facilities, provided you maintain
-    clear directions next to the object code saying where to find the
-    Corresponding Source.  Regardless of what server hosts the
-    Corresponding Source, you remain obligated to ensure that it is
-    available for as long as needed to satisfy these requirements.
-
-    e) Convey the object code using peer-to-peer transmission, provided
-    you inform other peers where the object code and Corresponding
-    Source of the work are being offered to the general public at no
-    charge under subsection 6d.
-
-  A separable portion of the object code, whose source code is excluded
-from the Corresponding Source as a System Library, need not be
-included in conveying the object code work.
-
-  A "User Product" is either (1) a "consumer product", which means any
-tangible personal property which is normally used for personal, family,
-or household purposes, or (2) anything designed or sold for incorporation
-into a dwelling.  In determining whether a product is a consumer product,
-doubtful cases shall be resolved in favor of coverage.  For a particular
-product received by a particular user, "normally used" refers to a
-typical or common use of that class of product, regardless of the status
-of the particular user or of the way in which the particular user
-actually uses, or expects or is expected to use, the product.  A product
-is a consumer product regardless of whether the product has substantial
-commercial, industrial or non-consumer uses, unless such uses represent
-the only significant mode of use of the product.
-
-  "Installation Information" for a User Product means any methods,
-procedures, authorization keys, or other information required to install
-and execute modified versions of a covered work in that User Product from
-a modified version of its Corresponding Source.  The information must
-suffice to ensure that the continued functioning of the modified object
-code is in no case prevented or interfered with solely because
-modification has been made.
-
-  If you convey an object code work under this section in, or with, or
-specifically for use in, a User Product, and the conveying occurs as
-part of a transaction in which the right of possession and use of the
-User Product is transferred to the recipient in perpetuity or for a
-fixed term (regardless of how the transaction is characterized), the
-Corresponding Source conveyed under this section must be accompanied
-by the Installation Information.  But this requirement does not apply
-if neither you nor any third party retains the ability to install
-modified object code on the User Product (for example, the work has
-been installed in ROM).
-
-  The requirement to provide Installation Information does not include a
-requirement to continue to provide support service, warranty, or updates
-for a work that has been modified or installed by the recipient, or for
-the User Product in which it has been modified or installed.  Access to a
-network may be denied when the modification itself materially and
-adversely affects the operation of the network or violates the rules and
-protocols for communication across the network.
-
-  Corresponding Source conveyed, and Installation Information provided,
-in accord with this section must be in a format that is publicly
-documented (and with an implementation available to the public in
-source code form), and must require no special password or key for
-unpacking, reading or copying.
-
-  7. Additional Terms.
-
-  "Additional permissions" are terms that supplement the terms of this
-License by making exceptions from one or more of its conditions.
-Additional permissions that are applicable to the entire Program shall
-be treated as though they were included in this License, to the extent
-that they are valid under applicable law.  If additional permissions
-apply only to part of the Program, that part may be used separately
-under those permissions, but the entire Program remains governed by
-this License without regard to the additional permissions.
-
-  When you convey a copy of a covered work, you may at your option
-remove any additional permissions from that copy, or from any part of
-it.  (Additional permissions may be written to require their own
-removal in certain cases when you modify the work.)  You may place
-additional permissions on material, added by you to a covered work,
-for which you have or can give appropriate copyright permission.
-
-  Notwithstanding any other provision of this License, for material you
-add to a covered work, you may (if authorized by the copyright holders of
-that material) supplement the terms of this License with terms:
-
-    a) Disclaiming warranty or limiting liability differently from the
-    terms of sections 15 and 16 of this License; or
-
-    b) Requiring preservation of specified reasonable legal notices or
-    author attributions in that material or in the Appropriate Legal
-    Notices displayed by works containing it; or
-
-    c) Prohibiting misrepresentation of the origin of that material, or
-    requiring that modified versions of such material be marked in
-    reasonable ways as different from the original version; or
-
-    d) Limiting the use for publicity purposes of names of licensors or
-    authors of the material; or
-
-    e) Declining to grant rights under trademark law for use of some
-    trade names, trademarks, or service marks; or
-
-    f) Requiring indemnification of licensors and authors of that
-    material by anyone who conveys the material (or modified versions of
-    it) with contractual assumptions of liability to the recipient, for
-    any liability that these contractual assumptions directly impose on
-    those licensors and authors.
-
-  All other non-permissive additional terms are considered "further
-restrictions" within the meaning of section 10.  If the Program as you
-received it, or any part of it, contains a notice stating that it is
-governed by this License along with a term that is a further
-restriction, you may remove that term.  If a license document contains
-a further restriction but permits relicensing or conveying under this
-License, you may add to a covered work material governed by the terms
-of that license document, provided that the further restriction does
-not survive such relicensing or conveying.
-
-  If you add terms to a covered work in accord with this section, you
-must place, in the relevant source files, a statement of the
-additional terms that apply to those files, or a notice indicating
-where to find the applicable terms.
-
-  Additional terms, permissive or non-permissive, may be stated in the
-form of a separately written license, or stated as exceptions;
-the above requirements apply either way.
-
-  8. Termination.
-
-  You may not propagate or modify a covered work except as expressly
-provided under this License.  Any attempt otherwise to propagate or
-modify it is void, and will automatically terminate your rights under
-this License (including any patent licenses granted under the third
-paragraph of section 11).
-
-  However, if you cease all violation of this License, then your
-license from a particular copyright holder is reinstated (a)
-provisionally, unless and until the copyright holder explicitly and
-finally terminates your license, and (b) permanently, if the copyright
-holder fails to notify you of the violation by some reasonable means
-prior to 60 days after the cessation.
-
-  Moreover, your license from a particular copyright holder is
-reinstated permanently if the copyright holder notifies you of the
-violation by some reasonable means, this is the first time you have
-received notice of violation of this License (for any work) from that
-copyright holder, and you cure the violation prior to 30 days after
-your receipt of the notice.
-
-  Termination of your rights under this section does not terminate the
-licenses of parties who have received copies or rights from you under
-this License.  If your rights have been terminated and not permanently
-reinstated, you do not qualify to receive new licenses for the same
-material under section 10.
-
-  9. Acceptance Not Required for Having Copies.
-
-  You are not required to accept this License in order to receive or
-run a copy of the Program.  Ancillary propagation of a covered work
-occurring solely as a consequence of using peer-to-peer transmission
-to receive a copy likewise does not require acceptance.  However,
-nothing other than this License grants you permission to propagate or
-modify any covered work.  These actions infringe copyright if you do
-not accept this License.  Therefore, by modifying or propagating a
-covered work, you indicate your acceptance of this License to do so.
-
-  10. Automatic Licensing of Downstream Recipients.
-
-  Each time you convey a covered work, the recipient automatically
-receives a license from the original licensors, to run, modify and
-propagate that work, subject to this License.  You are not responsible
-for enforcing compliance by third parties with this License.
-
-  An "entity transaction" is a transaction transferring control of an
-organization, or substantially all assets of one, or subdividing an
-organization, or merging organizations.  If propagation of a covered
-work results from an entity transaction, each party to that
-transaction who receives a copy of the work also receives whatever
-licenses to the work the party's predecessor in interest had or could
-give under the previous paragraph, plus a right to possession of the
-Corresponding Source of the work from the predecessor in interest, if
-the predecessor has it or can get it with reasonable efforts.
-
-  You may not impose any further restrictions on the exercise of the
-rights granted or affirmed under this License.  For example, you may
-not impose a license fee, royalty, or other charge for exercise of
-rights granted under this License, and you may not initiate litigation
-(including a cross-claim or counterclaim in a lawsuit) alleging that
-any patent claim is infringed by making, using, selling, offering for
-sale, or importing the Program or any portion of it.
-
-  11. Patents.
-
-  A "contributor" is a copyright holder who authorizes use under this
-License of the Program or a work on which the Program is based.  The
-work thus licensed is called the contributor's "contributor version".
-
-  A contributor's "essential patent claims" are all patent claims
-owned or controlled by the contributor, whether already acquired or
-hereafter acquired, that would be infringed by some manner, permitted
-by this License, of making, using, or selling its contributor version,
-but do not include claims that would be infringed only as a
-consequence of further modification of the contributor version.  For
-purposes of this definition, "control" includes the right to grant
-patent sublicenses in a manner consistent with the requirements of
-this License.
-
-  Each contributor grants you a non-exclusive, worldwide, royalty-free
-patent license under the contributor's essential patent claims, to
-make, use, sell, offer for sale, import and otherwise run, modify and
-propagate the contents of its contributor version.
-
-  In the following three paragraphs, a "patent license" is any express
-agreement or commitment, however denominated, not to enforce a patent
-(such as an express permission to practice a patent or covenant not to
-sue for patent infringement).  To "grant" such a patent license to a
-party means to make such an agreement or commitment not to enforce a
-patent against the party.
-
-  If you convey a covered work, knowingly relying on a patent license,
-and the Corresponding Source of the work is not available for anyone
-to copy, free of charge and under the terms of this License, through a
-publicly available network server or other readily accessible means,
-then you must either (1) cause the Corresponding Source to be so
-available, or (2) arrange to deprive yourself of the benefit of the
-patent license for this particular work, or (3) arrange, in a manner
-consistent with the requirements of this License, to extend the patent
-license to downstream recipients.  "Knowingly relying" means you have
-actual knowledge that, but for the patent license, your conveying the
-covered work in a country, or your recipient's use of the covered work
-in a country, would infringe one or more identifiable patents in that
-country that you have reason to believe are valid.
-
-  If, pursuant to or in connection with a single transaction or
-arrangement, you convey, or propagate by procuring conveyance of, a
-covered work, and grant a patent license to some of the parties
-receiving the covered work authorizing them to use, propagate, modify
-or convey a specific copy of the covered work, then the patent license
-you grant is automatically extended to all recipients of the covered
-work and works based on it.
-
-  A patent license is "discriminatory" if it does not include within
-the scope of its coverage, prohibits the exercise of, or is
-conditioned on the non-exercise of one or more of the rights that are
-specifically granted under this License.  You may not convey a covered
-work if you are a party to an arrangement with a third party that is
-in the business of distributing software, under which you make payment
-to the third party based on the extent of your activity of conveying
-the work, and under which the third party grants, to any of the
-parties who would receive the covered work from you, a discriminatory
-patent license (a) in connection with copies of the covered work
-conveyed by you (or copies made from those copies), or (b) primarily
-for and in connection with specific products or compilations that
-contain the covered work, unless you entered into that arrangement,
-or that patent license was granted, prior to 28 March 2007.
-
-  Nothing in this License shall be construed as excluding or limiting
-any implied license or other defenses to infringement that may
-otherwise be available to you under applicable patent law.
-
-  12. No Surrender of Others' Freedom.
-
-  If conditions are imposed on you (whether by court order, agreement or
-otherwise) that contradict the conditions of this License, they do not
-excuse you from the conditions of this License.  If you cannot convey a
-covered work so as to satisfy simultaneously your obligations under this
-License and any other pertinent obligations, then as a consequence you may
-not convey it at all.  For example, if you agree to terms that obligate you
-to collect a royalty for further conveying from those to whom you convey
-the Program, the only way you could satisfy both those terms and this
-License would be to refrain entirely from conveying the Program.
-
-  13. Use with the GNU Affero General Public License.
-
-  Notwithstanding any other provision of this License, you have
-permission to link or combine any covered work with a work licensed
-under version 3 of the GNU Affero General Public License into a single
-combined work, and to convey the resulting work.  The terms of this
-License will continue to apply to the part which is the covered work,
-but the special requirements of the GNU Affero General Public License,
-section 13, concerning interaction through a network will apply to the
-combination as such.
-
-  14. Revised Versions of this License.
-
-  The Free Software Foundation may publish revised and/or new versions of
-the GNU General Public License from time to time.  Such new versions will
-be similar in spirit to the present version, but may differ in detail to
-address new problems or concerns.
-
-  Each version is given a distinguishing version number.  If the
-Program specifies that a certain numbered version of the GNU General
-Public License "or any later version" applies to it, you have the
-option of following the terms and conditions either of that numbered
-version or of any later version published by the Free Software
-Foundation.  If the Program does not specify a version number of the
-GNU General Public License, you may choose any version ever published
-by the Free Software Foundation.
-
-  If the Program specifies that a proxy can decide which future
-versions of the GNU General Public License can be used, that proxy's
-public statement of acceptance of a version permanently authorizes you
-to choose that version for the Program.
-
-  Later license versions may give you additional or different
-permissions.  However, no additional obligations are imposed on any
-author or copyright holder as a result of your choosing to follow a
-later version.
-
-  15. Disclaimer of Warranty.
-
-  THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
-APPLICABLE LAW.  EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
-HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
-OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
-IS WITH YOU.  SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
-ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
-
-  16. Limitation of Liability.
-
-  IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
-THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
-GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
-USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
-DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
-PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
-EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGES.
-
-  17. Interpretation of Sections 15 and 16.
-
-  If the disclaimer of warranty and limitation of liability provided
-above cannot be given local legal effect according to their terms,
-reviewing courts shall apply local law that most closely approximates
-an absolute waiver of all civil liability in connection with the
-Program, unless a warranty or assumption of liability accompanies a
-copy of the Program in return for a fee.
-
-                     END OF TERMS AND CONDITIONS
-
-            How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-state the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-Also add information on how to contact you by electronic and paper mail.
-
-  If the program does terminal interaction, make it output a short
-notice like this when it starts in an interactive mode:
-
-    <program>  Copyright (C) <year>  <name of author>
-    This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, your program's commands
-might be different; for a GUI interface, you would use an "about box".
-
-  You should also get your employer (if you work as a programmer) or school,
-if any, to sign a "copyright disclaimer" for the program, if necessary.
-For more information on this, and how to apply and follow the GNU GPL, see
-<https://www.gnu.org/licenses/>.
-
-  The GNU General Public License does not permit incorporating your program
-into proprietary programs.  If your program is a subroutine library, you
-may consider it more useful to permit linking proprietary applications with
-the library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.  But first, please read
-<https://www.gnu.org/licenses/why-not-lgpl.html>.

README.md

@@ -3,22 +3,18 @@
 ![PyPI - Python Version](https://img.shields.io/pypi/pyversions/ofx-processor)
 ![PyPI - Format](https://img.shields.io/pypi/format/ofx-processor)
 ![PyPI - Status](https://img.shields.io/pypi/status/ofx-processor)
-![GitHub release (latest by date including pre-releases)](https://img.shields.io/github/v/release/Crocmagnon/ofx-processor?include_prereleases)
-![License](https://img.shields.io/github/license/Crocmagnon/ofx-processor)
-![GitHub Workflow Status](https://img.shields.io/github/workflow/status/Crocmagnon/ofx-processor/Test%20&%20publish)
-![Sonar Coverage](https://img.shields.io/sonar/coverage/Crocmagnon_ofx-processor?server=https%3A%2F%2Fsonarcloud.io)
-[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=bugs)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Code Smells](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=code_smells)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=alert_status)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Security Rating](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=security_rating)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
-[![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=Crocmagnon_ofx-processor&metric=sqale_index)](https://sonarcloud.io/dashboard?id=Crocmagnon_ofx-processor)
 
+## Install
+
+```shell
+python -m pip install ofx-processor
+```
+
+https://pypi.org/project/ofx-processor/
 
 ## Usage
 
-```shell script
+```
 Usage: ynab [OPTIONS] COMMAND [ARGS]...
 
   Import your data to YNAB with the processors listed below or manage your
@@ -46,3 +42,17 @@ The file passed in parameter will be deleted unless specified (`--keep` option o
 ## Versions
 
 This project follows [Semantic Versioning](https://semver.org/).
+
+## Development
+### Release
+```shell
+inv full-test
+poetry version <major/minor/patch>
+git add .
+git commit
+inv tag <version>
+inv publish publish-docker
+```
+
+# Reuse
+If you do reuse my work, please consider linking back to this repository 🙂

ofx_processor/downloaders/__init__.py

@@ -0,0 +1 @@
+from .lcl import LclDownloader

ofx_processor/downloaders/lcl.py

@@ -0,0 +1,88 @@
+import time
+from pathlib import Path
+
+import click
+from selenium import webdriver
+from selenium.webdriver.common.by import By
+from selenium.webdriver.support.select import Select
+
+from ofx_processor.utils.config import (
+    get_config,
+    get_config_file_name,
+    handle_config_file_error,
+)
+
+
+class LclDownloader:
+    def __init__(self, download_folder: Path = None):
+        self.config = get_config("lcl")
+        if not self.config.bank_identifier or not self.config.bank_password:
+            handle_config_file_error(
+                get_config_file_name(), "Missing credentials in config file"
+            )
+
+        if not download_folder:
+            download_folder = Path.home() / "Downloads"
+        self.download_folder = download_folder.resolve()
+        options = webdriver.FirefoxOptions()
+        options.headless = True
+        options.set_preference("browser.download.dir", str(self.download_folder))
+        options.set_preference(
+            "browser.helperApps.neverAsk.saveToDisk", "application/x-ofx"
+        )
+        self.selenium = webdriver.Firefox(options=options)
+        self.selenium.implicitly_wait(30)
+
+    def download(self) -> str:
+        selenium = self.selenium
+
+        click.secho("Logging in to LCL...", fg="blue")
+        selenium.get("https://monespace.lcl.fr/connexion")
+        try:
+            self._click(By.ID, "popin_tc_privacy_button_2")
+        except:
+            # If the user has already accepted the privacy policy,
+            # the button is not present
+            pass
+        login_input = selenium.find_element(By.ID, "identifier")
+        login_input.send_keys(self.config.bank_identifier)
+        self._click(By.CLASS_NAME, "app-cta-button")
+        for char in self.config.bank_password:
+            self._click(By.CSS_SELECTOR, f".pad-button[value='{char}']")
+        self._click(By.CLASS_NAME, "app-cta-button")
+        click.secho("Logged in!", fg="green")
+
+        click.secho("Navigating through archives...", fg="blue")
+        self._click(By.ID, "linkSynthese")
+        self._click(By.CLASS_NAME, "picDl")
+        self._select(By.ID, "change", index=1)
+        self._select(By.ID, "DS", index=20)
+        self._click(By.ID, "MON04")
+        self._click(By.ID, "Valider")
+        click.secho("Found it!", fg="green")
+        selenium.get("about:downloads")
+        return self._get_last_download_file_name()
+
+    def _click(self, by: By, value: str):
+        self.selenium.find_element(by, value).click()
+
+    def _select(self, by: By, value: str, index: int):
+        Select(self.selenium.find_element(by, value)).select_by_index(index)
+
+    def _get_last_download_file_name(self, wait_seconds: int = 30):
+        end_time = time.time() + wait_seconds
+        while time.time() < end_time:
+            try:
+                file_name = self.selenium.execute_script(
+                    "return document.querySelector('#contentAreaDownloadsView .downloadMainArea .downloadContainer description:nth-of-type(1)').value"
+                )
+                if file_name:
+                    return self.download_folder / file_name
+            except:
+                pass
+            time.sleep(1)
+
+
+if __name__ == "__main__":
+    filename = LclDownloader().download()
+    print(filename)

ofx_processor/main.py

@@ -1,7 +1,8 @@
 import click
 
-from ofx_processor.utils import ynab
-from ofx_processor.utils.utils import discover_processors, OrderedGroup
+from ofx_processor import downloaders
+from ofx_processor.utils import config
+from ofx_processor.utils.utils import OrderedGroup, discover_processors
 
 CONTEXT_SETTINGS = dict(help_option_names=["-h", "--help"])
 
@@ -15,7 +16,7 @@ def cli():
     """
 
 
-cli.add_command(ynab.config, name="config")
+cli.add_command(config.config, name="config")
 discover_processors(cli)
 
 if __name__ == "__main__":

ofx_processor/processors/bpvf.py

@@ -33,6 +33,9 @@ class BpvfProcessor(OfxBaseProcessor):
     command_name = "bpvf"
 
 
-def main(filename, keep):
+def main(filename, keep, send_method):
     """Import BPVF bank statement (OFX file)."""
-    BpvfProcessor(filename).push_to_ynab(keep)
+    processor = BpvfProcessor(filename)
+    if send_method:
+        processor.send_reconciled_amount(send_method)
+    processor.push_to_ynab(keep)

ofx_processor/processors/ce.py

@@ -1,6 +1,6 @@
 import re
 
-from ofx_processor.utils.base_ofx import OfxBaseProcessor, OfxBaseLine
+from ofx_processor.utils.base_ofx import OfxBaseLine, OfxBaseProcessor
 
 
 class CeLine(OfxBaseLine):
@@ -30,6 +30,9 @@ class CeProcessor(OfxBaseProcessor):
     line_class = CeLine
 
 
-def main(filename, keep):
+def main(filename, keep, send_method):
     """Import CE bank statement (OFX file)."""
-    CeProcessor(filename).push_to_ynab(keep)
+    processor = CeProcessor(filename)
+    if send_method:
+        processor.send_reconciled_amount(send_method)
+    processor.push_to_ynab(keep)

ofx_processor/processors/lcl.py

@@ -4,6 +4,7 @@ from datetime import datetime
 import click
 import dateparser
 
+from ofx_processor.downloaders import LclDownloader
 from ofx_processor.utils.base_ofx import OfxBaseLine, OfxBaseProcessor
 
 
@@ -56,12 +57,12 @@ class LclProcessor(OfxBaseProcessor):
     account_name = "lcl"
     command_name = "lcl"
 
-    def parse_file(self):
+    def _parse_file(self):
         # The first line of this file needs to be removed.
         # It contains something that is not part of the header of an OFX file.
         try:
             with open(self.filename, "r") as user_file:
-                data = user_file.read().splitlines(True)
+                data = user_file.read().splitlines(keepends=True)
         except FileNotFoundError:
             click.secho("Couldn't find ofx file", fg="red")
             sys.exit(1)
@@ -70,15 +71,27 @@ class LclProcessor(OfxBaseProcessor):
             with open(self.filename, "w") as temp_file:
                 temp_file.writelines(data[1:])
 
-        transactions = super(LclProcessor, self).parse_file()
+        ofx = super()._parse_file()
 
         if "Content-Type:" in data[0]:
             with open(self.filename, "w") as temp_file:
                 temp_file.writelines(data)
 
-        return transactions
+        return ofx
 
 
-def main(filename, keep):
+def main(filename, keep, download, send_method, push_to_ynab):
     """Import LCL bank statement (OFX file)."""
-    LclProcessor(filename).push_to_ynab(keep)
+    if download:
+        if filename:
+            click.secho(
+                "You can't specify a file name with auto download. "
+                "Specified file name will be ignored.",
+                fg="yellow",
+            )
+        filename = LclDownloader().download()
+    processor = LclProcessor(filename)
+    if send_method:
+        processor.send_reconciled_amount(send_method)
+    if push_to_ynab:
+        processor.push_to_ynab(keep)

ofx_processor/processors/revolut.py

@@ -5,7 +5,7 @@ import sys
 import click
 import dateparser
 
-from ofx_processor.utils.base_processor import BaseProcessor, BaseLine
+from ofx_processor.utils.base_processor import BaseLine, BaseProcessor
 
 
 def _amount_str_to_float(amount: str):

ofx_processor/utils/base_ofx.py

@@ -1,10 +1,14 @@
 import sys
+from decimal import Decimal
 
 import click
+import requests
 from ofxtools import OFXTree
 from ofxtools.header import OFXHeaderError
+from ofxtools.models import Aggregate
 
 from ofx_processor.utils.base_processor import BaseLine, BaseProcessor
+from ofx_processor.utils.config import get_config
 
 
 class OfxBaseLine(BaseLine):
@@ -23,14 +27,64 @@ class OfxBaseLine(BaseLine):
 
 class OfxBaseProcessor(BaseProcessor):
     line_class = OfxBaseLine
+    account_name = ""
 
     def parse_file(self):
+        ofx = self._parse_file()
+        return ofx.statements[0].transactions
+
+    def send_reconciled_amount(self, method):
+        amount = self._get_reconciled_amount()
+        click.secho(f"Reconciled balance: {amount}. Sending via {method}...", fg="blue")
+        if method == "email":
+            self._send_mail(amount)
+        elif method == "sms":
+            self._send_sms(amount)
+
+    def _get_reconciled_amount(self) -> Decimal:
+        ofx = self._parse_file()
+        return ofx.statements[0].balance.balamt
+
+    def _parse_file(self) -> Aggregate:
         parser = OFXTree()
         try:
             parser.parse(self.filename)
         except (FileNotFoundError, OFXHeaderError):
             click.secho("Couldn't open or parse ofx file", fg="red")
             sys.exit(1)
-
         ofx = parser.convert()
-        return ofx.statements[0].transactions
+        return ofx
+
+    def _send_mail(self, amount: Decimal):
+        config = get_config(self.account_name)
+        if not config.email_setup:
+            click.secho("Email is not properly setup", fg="yellow")
+            return
+        res = requests.post(
+            f"https://api.mailgun.net/v3/{config.mailgun_domain}/messages",
+            auth=("api", config.mailgun_api_key),
+            data={
+                "from": config.mailgun_from,
+                "to": [config.email_recipient],
+                "subject": f"Reconciled balance: {amount}",
+                "text": f"Here's your reconciled balance: {amount}",
+            },
+        )
+        if res.status_code >= 400:
+            click.secho("Error while sending email", fg="yellow")
+
+    def _send_sms(self, amount: Decimal):
+        config = get_config(self.account_name)
+        if not config.sms_setup:
+            click.secho("SMS is not properly setup", fg="yellow")
+            return
+        res = requests.post(
+            f"https://smsapi.free-mobile.fr/sendmsg",
+            json={
+                "user": config.sms_user,
+                "pass": config.sms_key,
+                "msg": f"Reconciled balance: {amount}",
+            },
+        )
+        if res.status_code >= 400:
+            click.secho("Error while sending SMS", fg="yellow")

ofx_processor/utils/base_processor.py

@@ -47,7 +47,7 @@ class BaseProcessor:
     account_name = None
 
     def __init__(self, filename):
-        self.filename = filename
+        self.filename = str(filename)
         self.iterable = self.parse_file()
         self.transaction_ids = defaultdict(int)
 

ofx_processor/utils/config.py

@@ -0,0 +1,149 @@
+import configparser
+import os
+import sys
+from dataclasses import dataclass
+from typing import Optional
+
+import click
+
+DEFAULT_CONFIG_DIR = click.get_app_dir("ofx_processor")
+DEFAULT_CONFIG_FILENAME = "config.ini"
+
+
+def get_default_config():
+    default_config = configparser.ConfigParser()
+    default_config["DEFAULT"] = {
+        "token": "<YOUR API TOKEN>",
+        "budget": "<YOUR BUDGET ID>",
+        "mailgun_api_key": "",
+        "mailgun_domain": "",
+        "mailgun_from": "",
+        "email_recipient": "",
+    }
+    default_config["bpvf"] = {"account": "<YOUR ACCOUNT ID>"}
+    default_config["revolut"] = {"account": "<YOUR ACCOUNT ID>"}
+    default_config["ce"] = {"account": "<YOUR ACCOUNT ID>"}
+    default_config["lcl"] = {
+        "account": "<YOUR ACCOUNT ID>",
+        "bank_identifier": "login",
+        "bank_password": "password",
+    }
+
+    return default_config
+
+
+def get_config_file_name():
+    config_file = os.path.join(DEFAULT_CONFIG_DIR, DEFAULT_CONFIG_FILENAME)
+    return config_file
+
+
+@click.group()
+def config():
+    """Manage configuration."""
+
+
+@config.command("edit", help="Edit the config file.")
+def edit_config():
+    config_file = get_config_file_name()
+    click.edit(filename=config_file)
+
+
+@config.command("file", help="Print the config file path.")
+def show_file_name():
+    config_file = get_config_file_name()
+    click.echo(config_file)
+
+
+@dataclass(frozen=True)
+class Config:
+    account: str
+    budget_id: str
+    token: str
+    bank_identifier: Optional[str] = None
+    bank_password: Optional[str] = None
+    mailgun_api_key: Optional[str] = None
+    mailgun_domain: Optional[str] = None
+    mailgun_from: Optional[str] = None
+    email_recipient: Optional[str] = None
+    sms_user: Optional[str] = None
+    sms_key: Optional[str] = None
+
+    @property
+    def email_setup(self) -> bool:
+        """Return true if all fields are setup for email."""
+        return all(
+            [
+                self.mailgun_from,
+                self.mailgun_domain,
+                self.mailgun_api_key,
+                self.email_recipient,
+            ]
+        )
+
+    @property
+    def sms_setup(self) -> bool:
+        """Return true if all fields are setup for sms."""
+        return all(
+            [
+                self.sms_user,
+                self.sms_key,
+            ]
+        )
+
+
+def get_config(account: str) -> Config:
+    config = configparser.ConfigParser()
+    config_file = get_config_file_name()
+
+    if not os.path.isfile(config_file):
+        os.makedirs(DEFAULT_CONFIG_DIR, exist_ok=True)
+        config = get_default_config()
+        with open(config_file, "w") as file_:
+            config.write(file_)
+        click.secho("Editing config file...")
+        click.pause()
+        click.edit(filename=config_file)
+
+    try:
+        config.read(config_file)
+    except configparser.Error as e:
+        return handle_config_file_error(config_file, e)
+
+    try:
+        section = config[account]
+        budget_id = section["budget"]
+        token = section["token"]
+        account = section["account"]
+        bank_identifier = section.get("bank_identifier")
+        bank_password = section.get("bank_password")
+        mailgun_api_key = section.get("mailgun_api_key")
+        mailgun_domain = section.get("mailgun_domain")
+        mailgun_from = section.get("mailgun_from")
+        email_recipient = section.get("email_recipient")
+        sms_user = section.get("sms_user")
+        sms_key = section.get("sms_key")
+    except KeyError as e:
+        return handle_config_file_error(config_file, e)
+
+    return Config(
+        account,
+        budget_id,
+        token,
+        bank_identifier,
+        bank_password,
+        mailgun_api_key,
+        mailgun_domain,
+        mailgun_from,
+        email_recipient,
+        sms_user,
+        sms_key,
+    )
+
+
+def handle_config_file_error(config_file, e):
+    click.secho(f"Error while parsing config file: {str(e)}", fg="red", bold=True)
+    click.secho("Opening the file...")
+    click.pause()
+    click.edit(filename=config_file)
+    click.secho("Exiting...", fg="red", bold=True)
+    sys.exit(1)

ofx_processor/utils/utils.py

@@ -1,11 +1,52 @@
 import collections
 import importlib
+import inspect
 import pkgutil
 
 import click
 
 from ofx_processor import processors
 
+ARG_TO_OPTION = {
+    "keep": click.option(
+        "--keep/--no-keep",
+        help="Keep the file after processing it.",
+        default=False,
+        show_default=True,
+    ),
+    "send_method": click.option(
+        "send_method",
+        "-s",
+        "--send",
+        help=(
+            "Send the reconciled amount via the chosen method. "
+            "Accepted methods: sms, email"
+        ),
+        default="",
+        show_default=True,
+    ),
+    "download": click.option(
+        "--download/--no-download",
+        help="Download the file automatically.",
+        default=False,
+        show_default=True,
+    ),
+    "filename": click.option(
+        "-f",
+        "--filename",
+        help="Use specified file.",
+        default="",
+        show_default=True,
+    ),
+    "push_to_ynab": click.option(
+        "push_to_ynab",
+        "--push/--no-push",
+        help="Push the data to YNAB.",
+        default=True,
+        show_default=True,
+    ),
+}
+
 
 def discover_processors(cli: click.Group):
     """
@@ -41,13 +82,10 @@ def discover_processors(cli: click.Group):
 
                 # Apply default decorators
                 method = getattr(module, "main")
-                method = click.option(
-                    "--keep/--no-keep",
-                    help="Keep the file after processing it.",
-                    default=False,
-                    show_default=True,
-                )(method)
-                method = click.argument("filename")(method)
+                method_args = inspect.getfullargspec(method).args
+                for arg in method_args:
+                    if arg in ARG_TO_OPTION:
+                        method = ARG_TO_OPTION[arg](method)
                 method = click.command(cls.command_name)(method)
 
                 cli.add_command(method)
@@ -55,7 +93,7 @@ def discover_processors(cli: click.Group):
 
 class OrderedGroup(click.Group):
     def __init__(self, name=None, commands=None, **attrs):
-        super(OrderedGroup, self).__init__(name, commands, **attrs)
+        super().__init__(name, commands, **attrs)
         #: the registered subcommands by their exported names.
         self.commands = commands or collections.OrderedDict()
 

ofx_processor/utils/ynab.py

@@ -1,81 +1,29 @@
-import configparser
-import os
-import sys
-
 import click
 import requests
 
+from ofx_processor.utils.config import get_config
+
 BASE_URL = "https://api.youneedabudget.com/v1"
-DEFAULT_CONFIG_DIR = click.get_app_dir("ofx_processor")
-DEFAULT_CONFIG_FILENAME = "config.ini"
-
-
-def get_default_config():
-    default_config = configparser.ConfigParser()
-    default_config["DEFAULT"] = {
-        "token": "<YOUR API TOKEN>",
-        "budget": "<YOUR BUDGET ID>",
-    }
-    default_config["bpvf"] = {"account": "<YOUR ACCOUNT ID>"}
-    default_config["revolut"] = {"account": "<YOUR ACCOUNT ID>"}
-    default_config["ce"] = {"account": "<YOUR ACCOUNT ID>"}
-
-    return default_config
-
-
-def get_config_file_name():
-    config_file = os.path.join(DEFAULT_CONFIG_DIR, DEFAULT_CONFIG_FILENAME)
-    return config_file
-
-
-@click.group()
-def config():
-    """Manage configuration."""
-
-
-@config.command("edit")
-def edit_config():
-    config_file = get_config_file_name()
-    click.edit(filename=config_file)
 
 
 def push_transactions(transactions, account):
     if not transactions:
         click.secho("No transaction, nothing to do.", fg="yellow")
         return
-    config = configparser.ConfigParser()
-    config_file = get_config_file_name()
-    if not os.path.isfile(config_file):
-        os.makedirs(DEFAULT_CONFIG_DIR, exist_ok=True)
-        config = get_default_config()
-        with open(config_file, "w") as file_:
-            config.write(file_)
-        click.secho("Editing config file...")
-        click.pause()
-        click.edit(filename=config_file)
+    config = get_config(account)
 
-    try:
-        config.read(config_file)
-    except configparser.Error as e:
-        return handle_config_file_error(config_file, e)
-
-    try:
-        section = config[account]
-        budget_id = section["budget"]
-        token = section["token"]
-        account = section["account"]
-    except KeyError as e:
-        return handle_config_file_error(config_file, e)
-
-    url = f"{BASE_URL}/budgets/{budget_id}/transactions"
+    url = f"{BASE_URL}/budgets/{config.budget_id}/transactions"
     for transaction in transactions:
-        transaction["account_id"] = account
+        transaction["account_id"] = config.account
+        transaction["cleared"] = "cleared"
 
     data = {"transactions": transactions}
-    headers = {"Authorization": f"Bearer {token}"}
+    headers = {"Authorization": f"Bearer {config.token}"}
 
     res = requests.post(url, json=data, headers=headers)
-    res.raise_for_status()
+    if res.status_code >= 400:
+        click.secho(f"Error pushing transactions: {res.text}", fg="red")
+        return
     data = res.json()["data"]
 
     created = set()
@@ -94,12 +42,3 @@ def push_transactions(transactions, account):
         click.secho(
             f"{len(duplicates)} transactions ignored (duplicates).", fg="yellow"
         )
-
-
-def handle_config_file_error(config_file, e):
-    click.secho(f"Error while parsing config file: {str(e)}", fg="red", bold=True)
-    click.secho("Opening the file...")
-    click.pause()
-    click.edit(filename=config_file)
-    click.secho("Exiting...", fg="red", bold=True)
-    sys.exit(1)

pyproject.toml

@@ -1,9 +1,8 @@
 [tool.poetry]
 name = "ofx-processor"
-version = "2.1.4"
+version = "4.1.0"
 description = "Personal ofx processor"
 readme = "README.md"
-license = "GPL-3.0-or-later"
 authors = ["Gabriel Augendre <gabriel@augendre.info>"]
 homepage = "https://git.augendre.info/gaugendre/ofx-processor"
 repository = "https://git.augendre.info/gaugendre/ofx-processor"
@@ -16,32 +15,60 @@ classifiers = [
     "Development Status :: 5 - Production/Stable",
     "Environment :: Console",
     "Intended Audience :: End Users/Desktop",
-    "License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)",
+    "License :: OSI Approved :: The Unlicense (Unlicense)",
     "Natural Language :: English",
     "Operating System :: MacOS :: MacOS X",
     "Operating System :: Microsoft :: Windows",
     "Operating System :: Unix",
-    "Programming Language :: Python :: 3.7",
     "Programming Language :: Python :: 3.8",
+    "Programming Language :: Python :: 3.9",
+    "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3 :: Only",
     "Topic :: Utilities",
 ]
 
 [tool.poetry.dependencies]
-python = ">=3.7,<4"
-ofxtools = "^0.8.22"
-click = "^7.1.2"
-dateparser = "^0.7.6"
+python = ">=3.8,<4"
+ofxtools = "^0.9.4"
+click = "^8.0.3"
+dateparser = "^1.1.0"
 requests = "^2.24.0"
+selenium = "^4.0.0"
 
 [tool.poetry.dev-dependencies]
 pytest = "^6.0.1"
-black = "^20.8b1"
-coverage = "^5.2.1"
+pytest-cov = "^3.0.0"
+invoke = "^1.6.0"
+pre-commit = "^2.15.0"
+tox = "^3.24.4"
+pdbpp = "^0.10.3"
 
 [tool.poetry.scripts]
 ynab = 'ofx_processor.main:cli'
 
+[tool.black]
+target-version = ['py38']
+
+[tool.isort]
+profile = "black"
+
+[tool.tox]
+legacy_tox_ini = """
+[tox]
+isolated_build = true
+envlist = py38, py39, py310
+
+[testenv]
+whitelist_externals = poetry
+commands =
+    poetry install --remove-untracked
+    poetry run inv test
+"""
+
+[tool.coverage.run]
+omit = ["tasks.py"]
+branch = true
+
 [build-system]
-requires = ["poetry>=0.12"]
-build-backend = "poetry.masonry.api"
+requires = ["poetry-core>=1.0.0"]
+build-backend = "poetry.core.masonry.api"

tasks.py

@@ -0,0 +1,58 @@
+import os
+from pathlib import Path
+
+from invoke import task
+
+BASE_DIR = Path(__file__).parent.resolve(strict=True)
+
+
+@task
+def test(ctx):
+    with ctx.cd(BASE_DIR):
+        ctx.run(f"pytest", pty=True, echo=True)
+
+
+@task
+def test_cov(ctx):
+    with ctx.cd(BASE_DIR):
+        ctx.run(
+            f"pytest --cov=. --cov-report term-missing:skip-covered",
+            pty=True,
+            echo=True,
+        )
+
+
+@task
+def full_test(ctx):
+    with ctx.cd(BASE_DIR):
+        ctx.run(f"tox", pty=True, echo=True)
+
+
+@task
+def publish(ctx):
+    username = os.getenv("PYPI_USERNAME")
+    password = os.getenv("PYPI_TOKEN")
+    with ctx.cd(BASE_DIR):
+        args = ""
+        if username and password:
+            args = f"--username {username} --password {password}"
+        ctx.run(f"poetry publish --build {args}", pty=True, echo=False)
+
+
+@task
+def publish_docker(ctx):
+    with ctx.cd(BASE_DIR):
+        docker_image = "crocmagnon/ynab"
+        ctx.run(
+            f"docker build --pull --platform linux/amd64 --build-arg OFX_VERSION=$(poetry version -s) -t {docker_image} .",
+            pty=True,
+            echo=True,
+        )
+        ctx.run(f"docker push {docker_image}", pty=True, echo=True)
+
+
+@task
+def tag(ctx, tag_name):
+    with ctx.cd(BASE_DIR):
+        ctx.run(f'git tag {tag_name} -am "{tag_name}"', pty=True, echo=True)
+        ctx.run(f"git push origin {tag_name}", pty=True, echo=True)

tests/samples/bpvf_transactions.json

@@ -6,7 +6,8 @@
       "payee_name": "PRLV SEPA Company 3",
       "memo": "123456789 PAYPAL 542UHBON",
       "import_id": "YNAB:-9660:2020-02-26:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-25",
@@ -14,7 +15,8 @@
       "payee_name": "H.I.K          69VILLEURBANNE",
       "memo": "240220 CB****5555",
       "import_id": "YNAB:-2400:2020-02-25:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-25",
@@ -22,7 +24,8 @@
       "payee_name": "DELIVEROO      FR WWW",
       "memo": "230220 CB****5555 39,20EUR 1 EURO = 1,000000",
       "import_id": "YNAB:-39200:2020-02-25:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-25",
@@ -30,7 +33,8 @@
       "payee_name": "PRLV SEPA Company 1",
       "memo": "Votre abonnement mobile: 06XXXXX 6498165189060897",
       "import_id": "YNAB:-9990:2020-02-25:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -38,7 +42,8 @@
       "payee_name": "COMPANY FR LYON 6EME",
       "memo": "210220 CB****5555 7,50EUR 1 EURO = 1,000000",
       "import_id": "YNAB:-7500:2020-02-24:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -46,7 +51,8 @@
       "payee_name": "PRLV SEPA Company 2",
       "memo": "24-02-2020 / 22-03-2020 56418710",
       "import_id": "YNAB:-34990:2020-02-24:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -54,7 +60,8 @@
       "payee_name": "VIR Person 1",
       "memo": "481840871 Splitwise",
       "import_id": "YNAB:-2390:2020-02-24:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-20",
@@ -62,7 +69,8 @@
       "payee_name": "VIREMENT Person 2",
       "memo": "Cadeau",
       "import_id": "YNAB:235000:2020-02-20:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-20",
@@ -70,7 +78,8 @@
       "payee_name": "VIREMENT Company 3",
       "memo": "48716508719",
       "import_id": "YNAB:55000:2020-02-20:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-19",
@@ -78,7 +87,8 @@
       "payee_name": "BDE INSA LYON  69VILLEURBANNE",
       "memo": "170220 CB****5555",
       "import_id": "YNAB:-55000:2020-02-19:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-19",
@@ -86,7 +96,8 @@
       "payee_name": "GUY AND SONS   FR LYON",
       "memo": "180220 CB****5555 0,90EUR 1 EURO = 1,000000",
       "import_id": "YNAB:-900:2020-02-19:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-19",
@@ -94,7 +105,8 @@
       "payee_name": "GUY AND SONS   FR LYON",
       "memo": "170220 CB****5555 1,40EUR 1 EURO = 1,000000",
       "import_id": "YNAB:-1400:2020-02-19:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-19",
@@ -102,7 +114,8 @@
       "payee_name": "VIR Person 1",
       "memo": "65187460 Acompte cuisine 2",
       "import_id": "YNAB:-473500:2020-02-19:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-18",
@@ -110,7 +123,8 @@
       "payee_name": "PRLV SEPA Company 4",
       "memo": "487105874 Amazon.fr 3X QC.(OJBIYN:ZOFEUBZF51871",
       "import_id": "YNAB:-96960:2020-02-18:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-17",
@@ -118,7 +132,8 @@
       "payee_name": "GRAND PARC PUY 85LES EPESSES",
       "memo": "150220 CB****5555",
       "import_id": "YNAB:-232000:2020-02-17:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-17",
@@ -126,7 +141,8 @@
       "payee_name": "UBER BV        NL HELP.UBER.CO",
       "memo": "140220 CB****5555 1,00EUR 1 EURO = 1,000000",
       "import_id": "YNAB:-1000:2020-02-17:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-17",
@@ -134,7 +150,8 @@
       "payee_name": "VIREMENT Person 5",
       "memo": "VIREMENT DE PERSON 6",
       "import_id": "YNAB:8600:2020-02-17:1",
-      "account_id": "<YOUR BPVF ACCOUNT ID>"
+      "account_id": "<YOUR BPVF ACCOUNT ID>",
+      "cleared": "cleared"
     }
   ]
 }

tests/samples/ce_transactions.json

@@ -6,7 +6,8 @@
       "payee_name": "CB DECATHLON",
       "memo": "FACT 240220",
       "import_id": "YNAB:-21000:2020-02-25:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-25",
@@ -14,7 +15,8 @@
       "payee_name": "PRLV COMPANY",
       "memo": "Company Ref Prlvt SEPA 99-1KIBHEF-01 45871984",
       "import_id": "YNAB:-7000:2020-02-25:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -22,7 +24,8 @@
       "payee_name": "CB 3403 MONOP",
       "memo": "FACT 210220",
       "import_id": "YNAB:-48130:2020-02-24:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -30,7 +33,8 @@
       "payee_name": "CB MALATIER",
       "memo": "FACT 210220",
       "import_id": "YNAB:-1200:2020-02-24:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -38,7 +42,8 @@
       "payee_name": "VIR SEPA PERSON 1",
       "memo": "_",
       "import_id": "YNAB:2390:2020-02-24:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-02-24",
@@ -46,7 +51,8 @@
       "payee_name": "VIR SEPA PERSON 2",
       "memo": "_",
       "import_id": "YNAB:14490:2020-02-24:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     }
   ]
 }

tests/samples/lcl_transactions.json

@@ -6,7 +6,8 @@
       "payee_name": "VIR INST M PAYEE 1",
       "memo": null,
       "import_id": "YNAB:1000000:2020-03-12:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-07-17",
@@ -14,7 +15,8 @@
       "payee_name": "CB IKEA",
       "memo": null,
       "import_id": "YNAB:-400450:2020-07-17:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-07-21",
@@ -22,7 +24,8 @@
       "payee_name": "CHQ",
       "memo": "CHQ 1234567",
       "import_id": "YNAB:-42000:2020-07-21:1",
-      "account_id": "<YOUR CE ACCOUNT ID>"
+      "account_id": "<YOUR CE ACCOUNT ID>",
+      "cleared": "cleared"
     }
   ]
 }

tests/samples/revolut_transactions.json

@@ -6,7 +6,8 @@
       "payee_name": "Virement de NAME",
       "memo": "Transferts",
       "import_id": "YNAB:1500000:2021-08-30:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-29",
@@ -14,7 +15,8 @@
       "payee_name": "To Person 1",
       "memo": "Transfers",
       "import_id": "YNAB:-53630:2020-01-29:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-29",
@@ -22,7 +24,8 @@
       "payee_name": "To Person 2",
       "memo": "Transfers",
       "import_id": "YNAB:-900:2020-01-29:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-29",
@@ -30,7 +33,8 @@
       "payee_name": "Refund from Company 2",
       "memo": "Shopping",
       "import_id": "YNAB:53630:2020-01-29:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-24",
@@ -38,7 +42,8 @@
       "payee_name": "To Person 3",
       "memo": "Transfers",
       "import_id": "YNAB:-8500:2020-01-24:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-16",
@@ -46,7 +51,8 @@
       "payee_name": "To Person 4",
       "memo": "Transfers",
       "import_id": "YNAB:-1400:2020-01-16:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-10",
@@ -54,7 +60,8 @@
       "payee_name": "To Person 5",
       "memo": "Transfers",
       "import_id": "YNAB:-2009:2020-01-10:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-10",
@@ -62,15 +69,17 @@
       "payee_name": "To Person 6",
       "memo": "Transfers",
       "import_id": "YNAB:-1210:2020-01-10:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-05",
       "amount": -123680,
       "payee_name": "Company 1",
-      "memo": "Shopping - FX-rate €1 = US$1,1158",
+      "memo": "Shopping - FX-rate \u20ac1\u2008=\u2008US$1,1158",
       "import_id": "YNAB:-123680:2020-01-05:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     },
     {
       "date": "2020-01-04",
@@ -78,7 +87,8 @@
       "payee_name": "Top-up via Apple Pay",
       "memo": "General",
       "import_id": "YNAB:100000:2020-01-04:1",
-      "account_id": "<YOUR REVOLUT ACCOUNT ID>"
+      "account_id": "<YOUR REVOLUT ACCOUNT ID>",
+      "cleared": "cleared"
     }
   ]
 }

tests/test_end_to_end.py

@@ -7,9 +7,9 @@ from unittest.mock import call
 
 from click.testing import CliRunner
 
-from ofx_processor.utils import utils
-from ofx_processor.utils import ynab
-from ofx_processor.utils.ynab import config
+import ofx_processor.utils.config
+from ofx_processor.utils import utils, ynab
+from ofx_processor.utils.config import config
 
 
 class UtilsTestCase(unittest.TestCase):
@@ -39,13 +39,14 @@ class ConfigTestCase(unittest.TestCase):
 
         # This is run at import time and the cli module is already imported before this test
         # so we need to re-run the add_command to make it available.
-        cli.add_command(ynab.config, name="config")
+        cli.add_command(ofx_processor.utils.config.config, name="config")
         utils.discover_processors(cli)
         self.cli = cli
 
     @mock.patch("click.edit")
     @mock.patch(
-        "ofx_processor.utils.ynab.DEFAULT_CONFIG_DIR", os.path.join("tests", "samples")
+        "ofx_processor.utils.config.DEFAULT_CONFIG_DIR",
+        os.path.join("tests", "samples"),
     )
     def test_config_edit(self, edit):
         runner = CliRunner()
@@ -56,11 +57,12 @@ class ConfigTestCase(unittest.TestCase):
 
     @mock.patch("click.edit")
     @mock.patch(
-        "ofx_processor.utils.ynab.DEFAULT_CONFIG_FILENAME",
+        "ofx_processor.utils.config.DEFAULT_CONFIG_FILENAME",
         "config_broken_duplicate_key.ini",
     )
     @mock.patch(
-        "ofx_processor.utils.ynab.DEFAULT_CONFIG_DIR", os.path.join("tests", "samples")
+        "ofx_processor.utils.config.DEFAULT_CONFIG_DIR",
+        os.path.join("tests", "samples"),
     )
     def test_broken_config_file(self, edit):
         broken_files = [
@@ -71,45 +73,56 @@ class ConfigTestCase(unittest.TestCase):
             "config_broken_missing_token.ini",
         ]
         for name in broken_files:
-            with mock.patch("ofx_processor.utils.ynab.DEFAULT_CONFIG_FILENAME", name):
+            with mock.patch("ofx_processor.utils.config.DEFAULT_CONFIG_FILENAME", name):
                 runner = CliRunner()
                 result = runner.invoke(
-                    self.cli, ["revolut", "tests/samples/revolut.csv", "--keep"]
+                    self.cli, ["revolut", "-f", "tests/samples/revolut.csv", "--keep"]
+                )
+                expected_filename = ofx_processor.utils.config.get_config_file_name()
+                self.assertIn(
+                    "Error while parsing config file",
+                    result.output,
+                    f"config_file: {name}",
                 )
-                expected_filename = ynab.get_config_file_name()
-                self.assertIn("Error while parsing config file", result.output, f"config_file: {name}")
                 edit.assert_called_with(filename=expected_filename)
 
-    @mock.patch("ofx_processor.utils.ynab.DEFAULT_CONFIG_FILENAME", "file.ini")
+    @mock.patch("ofx_processor.utils.config.DEFAULT_CONFIG_FILENAME", "file.ini")
     @mock.patch(
-        "ofx_processor.utils.ynab.DEFAULT_CONFIG_DIR",
+        "ofx_processor.utils.config.DEFAULT_CONFIG_DIR",
         os.path.join("some", "config", "folder"),
     )
     def test_get_config_file_name(self):
         expected = os.path.join("some", "config", "folder", "file.ini")
-        self.assertEqual(ynab.get_config_file_name(), expected)
+        self.assertEqual(ofx_processor.utils.config.get_config_file_name(), expected)
 
+    @mock.patch("requests.post")
     @mock.patch("click.edit")
     @mock.patch("os.makedirs")
-    @mock.patch("ofx_processor.utils.ynab.DEFAULT_CONFIG_FILENAME", "notfound.ini")
+    @mock.patch("ofx_processor.utils.config.DEFAULT_CONFIG_FILENAME", "notfound.ini")
     @mock.patch(
-        "ofx_processor.utils.ynab.DEFAULT_CONFIG_DIR", os.path.join("tests", "samples")
+        "ofx_processor.utils.config.DEFAULT_CONFIG_DIR",
+        os.path.join("tests", "samples"),
     )
-    def test_missing_config_file(self, makedirs, edit):
+    def test_missing_config_file(self, makedirs, edit, *args):
         runner = CliRunner()
-        with mock.patch("ofx_processor.utils.ynab.open", mock.mock_open()) as mock_file:
+        with mock.patch(
+            "ofx_processor.utils.config.open", mock.mock_open()
+        ) as mock_file:
             result = runner.invoke(
-                self.cli, ["revolut", "tests/samples/revolut.csv", "--keep"]
+                self.cli, ["revolut", "-f", "tests/samples/revolut.csv", "--keep"]
             )
             mock_file.assert_called_once()
-        makedirs.assert_called_once_with(ynab.DEFAULT_CONFIG_DIR, exist_ok=True)
+        makedirs.assert_called_once_with(
+            ofx_processor.utils.config.DEFAULT_CONFIG_DIR, exist_ok=True
+        )
         self.assertIn("Editing config file", result.output)
-        expected_filename = ynab.get_config_file_name()
+        expected_filename = ofx_processor.utils.config.get_config_file_name()
         edit.assert_called_once_with(filename=expected_filename)
+        # post.assert_not_called()
 
 
 @mock.patch(
-    "ofx_processor.utils.ynab.DEFAULT_CONFIG_DIR", os.path.join("tests", "samples")
+    "ofx_processor.utils.config.DEFAULT_CONFIG_DIR", os.path.join("tests", "samples")
 )
 class DataTestCase(unittest.TestCase):
     def setUp(self):
@@ -117,12 +130,13 @@ class DataTestCase(unittest.TestCase):
 
         # This is run at import time and the cli module is already imported before this test
         # so we need to re-run the add_command to make it available.
-        cli.add_command(ynab.config, name="config")
+        cli.add_command(ofx_processor.utils.config.config, name="config")
         utils.discover_processors(cli)
         self.cli = cli
 
     @mock.patch("requests.post")
-    def test_file_is_deleted_by_default(self, *args):
+    def test_file_is_deleted_by_default(self, post):
+        post.return_value.status_code = 201
         runner = CliRunner()
         revolut_csv = "tests/samples/revolut.csv"
         backup_file = "tests/samples/backup.csv"
@@ -132,7 +146,7 @@ class DataTestCase(unittest.TestCase):
 
         try:
             self.assertTrue(os.path.isfile(revolut_csv))
-            result = runner.invoke(self.cli, ["revolut", revolut_csv])
+            result = runner.invoke(self.cli, ["revolut", "-f", revolut_csv])
             self.assertEqual(result.exit_code, 0)
             self.assertFalse(os.path.isfile(revolut_csv))
         finally:
@@ -141,7 +155,8 @@ class DataTestCase(unittest.TestCase):
             os.unlink(backup_file)
 
     @mock.patch("requests.post")
-    def test_file_is_kept_with_option(self, *args):
+    def test_file_is_kept_with_option(self, post):
+        post.return_value.status_code = 201
         runner = CliRunner()
         revolut_csv = "tests/samples/revolut.csv"
         backup_file = "tests/samples/backup.csv"
@@ -151,7 +166,9 @@ class DataTestCase(unittest.TestCase):
 
         try:
             self.assertTrue(os.path.isfile(revolut_csv))
-            result = runner.invoke(self.cli, ["revolut", revolut_csv, "--keep"])
+            result = runner.invoke(
+                self.cli, ["revolut", "--filename", revolut_csv, "--keep"]
+            )
             self.assertEqual(result.exit_code, 0)
             self.assertTrue(os.path.isfile(revolut_csv))
         finally:
@@ -161,6 +178,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_revolut_sends_data_only_created(self, post):
+        post.return_value.status_code = 201
         post.return_value.json.return_value = {
             "data": {
                 "transactions": [
@@ -195,7 +213,7 @@ class DataTestCase(unittest.TestCase):
 
         runner = CliRunner()
         result = runner.invoke(
-            self.cli, ["revolut", "tests/samples/revolut.csv", "--keep"]
+            self.cli, ["revolut", "-f", "tests/samples/revolut.csv", "--keep"]
         )
 
         self.assertEqual(result.exit_code, 0)
@@ -205,6 +223,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_revolut_sends_data_some_created_some_duplicates(self, post):
+        post.return_value.status_code = 201
         post.return_value.json.return_value = {
             "data": {
                 "transactions": [
@@ -240,7 +259,7 @@ class DataTestCase(unittest.TestCase):
 
         runner = CliRunner()
         result = runner.invoke(
-            self.cli, ["revolut", "tests/samples/revolut.csv", "--keep"]
+            self.cli, ["revolut", "-f", "tests/samples/revolut.csv", "--keep"]
         )
 
         self.assertEqual(result.exit_code, 0)
@@ -250,6 +269,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_revolut_sends_data_only_duplicates(self, post):
+        post.return_value.status_code = 201
         post.return_value.json.return_value = {
             "data": {
                 "transactions": [],
@@ -270,7 +290,7 @@ class DataTestCase(unittest.TestCase):
 
         runner = CliRunner()
         result = runner.invoke(
-            self.cli, ["revolut", "tests/samples/revolut.csv", "--keep"]
+            self.cli, ["revolut", "-f", "tests/samples/revolut.csv", "--keep"]
         )
 
         self.assertEqual(result.exit_code, 0)
@@ -280,6 +300,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_bpvf_sends_to_ynab(self, post):
+        post.return_value.status_code = 201
         with open("tests/samples/bpvf_transactions.json", encoding="utf-8") as f:
             expected_data = json.load(f)
 
@@ -287,7 +308,7 @@ class DataTestCase(unittest.TestCase):
         expected_url = f"{ynab.BASE_URL}/budgets/<YOUR BUDGET ID>/transactions"
 
         runner = CliRunner()
-        runner.invoke(self.cli, ["bpvf", "tests/samples/bpvf.ofx", "--keep"])
+        runner.invoke(self.cli, ["bpvf", "-f", "tests/samples/bpvf.ofx", "--keep"])
 
         post.assert_called_once_with(
             expected_url, json=expected_data, headers=expected_headers
@@ -295,6 +316,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_ce_sends_to_ynab(self, post):
+        post.return_value.status_code = 201
         with open("tests/samples/ce_transactions.json", encoding="utf-8") as f:
             expected_data = json.load(f)
 
@@ -302,7 +324,7 @@ class DataTestCase(unittest.TestCase):
         expected_url = f"{ynab.BASE_URL}/budgets/<YOUR BUDGET ID>/transactions"
 
         runner = CliRunner()
-        runner.invoke(self.cli, ["ce", "tests/samples/ce.ofx", "--keep"])
+        runner.invoke(self.cli, ["ce", "-f", "tests/samples/ce.ofx", "--keep"])
 
         post.assert_called_once_with(
             expected_url, json=expected_data, headers=expected_headers
@@ -310,6 +332,7 @@ class DataTestCase(unittest.TestCase):
 
     @mock.patch("requests.post")
     def test_lcl_sends_to_ynab(self, post):
+        post.return_value.status_code = 201
         with open("tests/samples/lcl_transactions.json", encoding="utf-8") as f:
             expected_data = json.load(f)
 
@@ -317,7 +340,7 @@ class DataTestCase(unittest.TestCase):
         expected_url = f"{ynab.BASE_URL}/budgets/<YOUR BUDGET ID>/transactions"
 
         runner = CliRunner()
-        runner.invoke(self.cli, ["lcl", "tests/samples/lcl.ofx", "--keep"])
+        runner.invoke(self.cli, ["lcl", "-f", "tests/samples/lcl.ofx", "--keep"])
 
         post.assert_called_once_with(
             expected_url, json=expected_data, headers=expected_headers

tests/test_revolut_processor.py

@@ -3,9 +3,9 @@ import json
 import unittest
 
 from ofx_processor.processors.revolut import (
-    _amount_str_to_float,
     RevolutLine,
     RevolutProcessor,
+    _amount_str_to_float,
 )
 
 

tests/test_ynab_integration.py

@@ -2,13 +2,15 @@ import json
 import unittest
 from unittest import mock
 
+import ofx_processor.utils.config
 from ofx_processor.utils import ynab
 
 
 class YNABIntegrationTestCase(unittest.TestCase):
     @mock.patch("requests.post")
     def test_data_sent_to_ynab(self, post):
-        ynab.DEFAULT_CONFIG_DIR = "tests/samples"
+        post.return_value.status_code = 201
+        ofx_processor.utils.config.DEFAULT_CONFIG_DIR = "tests/samples"
 
         with open("tests/samples/revolut_expected.json", encoding="utf-8") as f:
             transactions = json.load(f)